Skip to content

Remove unused contributor endpoint #6547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

akatsoulas
Copy link
Collaborator

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR removes the unused contributor endpoint, cleaning up both the view code and URL mappings. Key changes include:

  • Removal of the add_to_contributors import from utils.
  • Deletion of the make_contributor view and its decorators.
  • Removal of the corresponding URL route from the users/urls.py file.

Reviewed Changes

File Description
kitsune/users/views.py Removed the unused make_contributor function and its imports.
kitsune/users/urls.py Removed the URL route mapping for the make_contributor endpoint.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

kitsune/users/views.py:375

  • [nitpick] Ensure that corresponding tests for the make_contributor endpoint are removed or updated to reflect the removal of this endpoint.
def make_contributor(request):

kitsune/users/urls.py:46

  • [nitpick] Review tests and any related documentation to ensure that references to the removed make_contributor endpoint have been updated accordingly.
re_path(r"^make_contributor$", views.make_contributor, name="users.make_contributor"),

@akatsoulas akatsoulas merged commit a0ea46a into mozilla:main Mar 11, 2025
2 checks passed
@akatsoulas akatsoulas deleted the rm-make-contributor branch March 11, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants